Fix DomCrawler html dumping example. #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,7 +190,7 @@ and :phpclass:`DOMNode` objects: | |||
| $html = ''; | |||
|
|
|||
| foreach ($crawler as $domElement) { | |||
| $html.= $domElement->ownerDocument->saveHTML(); | |||
| $html.= $domElement->ownerDocument->saveHTML($domElement); | |||
There was a problem hiding this comment.
while it is not your mistake, could you please add a space between $html and .=?
|
👍 |
|
Done. |
|
Some more research turned out that this sidebar give us an example on how to get the HTML of the complete |
|
I'm not sure that you got it correctly. Here is an example where the crawler represents all b tags in the document. Current doc example outputs the whole document twice (like we didn't filter the crawler). After my fix it prints 2 b tags. use Symfony\Component\DomCrawler\Crawler;
$crawler = new Crawler('<b>1</b><i>2</i><b>3</b>');
$html = '';
foreach ($crawler->filter('b') as $domElement) {
$html.= $domElement->ownerDocument->saveHTML();
}
echo $html;<_root><html><body><b>1</b><i>2</i><b>3</b></body></html></_root>
<_root><html><body><b>1</b><i>2</i><b>3</b></body></html></_root>use Symfony\Component\DomCrawler\Crawler;
$crawler = new Crawler('<b>1</b><i>2</i><b>3</b>');
$html = '';
foreach ($crawler->filter('b') as $domElement) {
$html .= $domElement->ownerDocument->saveHTML($domElement);
}
echo $html;<b>1</b><b>3</b> |
|
Ah, I understand what you mean. You're correct. 👍 |
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2013
Fix DomCrawler html dumping example.
|
Awesome guys, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current example collects HTML of the whole documents instead of required nodes.